Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs for flat_map should reference concat_map but instead reference flat_map #589

Open
dagardner-nv opened this issue Sep 12, 2022 · 1 comment · May be fixed by #590
Open

Docs for flat_map should reference concat_map but instead reference flat_map #589

dagardner-nv opened this issue Sep 12, 2022 · 1 comment · May be fixed by #590

Comments

@dagardner-nv
Copy link

dagardner-nv commented Sep 12, 2022 •
edited
Loading

Line in question:

Rx/v2/src/rxcpp/operators/rx-flat_map.hpp

Observables, produced by the CollectionSelector, are merged. There is another operator rxcpp::observable<T,SourceType>::flat_map that works similar but concatenates the observables.

Doxygen link:
http://reactivex.io/RxCpp/classrxcpp_1_1observable.html#ab1195b083ffa5a97fb1deb854c1e9bee
@dagardner-nv dagardner-nv linked a pull request Sep 12, 2022 that will close this issue
Open
@ghost
Copy link

ghost commented Oct 26, 2022 •
edited by ghost
Loading

Just hit this issue myself; looks like there are several other functions with the same mistake (e.g. concat_map, concat_transform, flat_map and merge_transform).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reference concat_map not flat_map in docs for flat_map dagardner-nv/RxCpp
1 participant
@dagardner-nv