Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem when using Dynamic Services () #80

Open
nuds-zhao opened this issue Feb 4, 2021 · 3 comments
Open

Problem when using Dynamic Services () #80

nuds-zhao opened this issue Feb 4, 2021 · 3 comments

Comments

@nuds-zhao
Copy link

Hi,
I deployed a developer version of the ncWMS server to solve the problem in Problem when using Dynamic Services #76. But one day all layers using Dynamic Services are failed to load, with the error of "The layer *** was not found on this server". I wonder if there is any problem with this version of ncWMS.

Btw, as I observed in the past month, the problem in Issue #76 is still there, although it's less frequent to appear.

@nuds-zhao
Copy link
Author

I find the reason why all layers can't be loaded.
I accidentally leave one empty Alias in the server:
empty_alias

It's quite difficult to identify this empty one from the default blank one. Hence I suggest that adding a condition before we match Alias with LayerName to prevent this situation in the NcwmsCatalogue.java:
before
after

@guygriffiths
Copy link
Collaborator

I'm not sure I follow. layerName.startsWith(null) will always return false - so explicitly testing that testDynamicService.getAlias() != null will never make a difference to that condition.

@nuds-zhao
Copy link
Author

Yeah, you are right. I made a mistake here. The empty Alias should correspond to an empty string. null may represent the default condition, so it would not make any difference. How about layerName.startsWith('')? What would that return? I think the correct condition to test should be testDynamicService.getAlias() != ''.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants