-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/api crypto get product [ 2 ] #209
Feature/api crypto get product [ 2 ] #209
Conversation
controllers/crypto.js
Outdated
|
||
const getProduct = async (req, res) => { | ||
try { | ||
const productId = req.params.productId |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
joi validation missing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is GET call to product/:productid, is validation necessary here?
This is being deleted as the contracts were updated, and the project is on hold currently |
Merge After #208
Closes Real-Dev-Squad/website-crypto#155