Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full-screen doesn't work for images/slide show #195

Open
agger-magenta opened this issue Dec 29, 2015 · 16 comments
Open

Full-screen doesn't work for images/slide show #195

agger-magenta opened this issue Dec 29, 2015 · 16 comments

Comments

@agger-magenta
Copy link
Contributor

When watching images in gallery view, there's a "toggle size" control, but it appears to be dimmed and doesn't work.

@fernao fernao added the bug label Feb 10, 2016
@sydro
Copy link
Contributor

sydro commented Feb 25, 2016

I think that it isn't a bug, the "toggle size" button is dimmed because the image is already in original full size.

@agger-magenta
Copy link
Contributor Author

I think it's not.

E.g. in this page:

http://baobaxia.modspil.dk/#mocambos/dpadua/bbx/search/

If you click on the first image, you'll get the lightbox view on only part of the screen.

However, if you click on the medium (text below the image) and click "baixar", you'll see that the image is actually much larger.

However, the lightbox is probably displaying a smaller version of the image, something between thumbnail and original size.

Hmmm, this raises the issue whether there should be an option to go full-screen with the original image. But since the present behaviour seems to be by design, that means this ticket is not a bug, but a feature request. We should probably leave it for now.

@20
Copy link
Member

20 commented Feb 26, 2016

Speaking with Sydro we agreed to maximize image (as big as possible) in slideshow view.. He's working on that!

@agger-magenta
Copy link
Contributor Author

Great! :-)

@sydro sydro self-assigned this Feb 27, 2016
@fernao
Copy link
Member

fernao commented Mar 19, 2016

Hi there,
I have an idea: set image height by default as window.innerHeight, what will get the current height of window.
The other fix is to create a real full screen, what depends on lightbox functionality.

@fernao
Copy link
Member

fernao commented Mar 19, 2016

The above commit changes config.js.example, so, copy the new config to config.js in order to manually set image size.

@agger-magenta
Copy link
Contributor Author

"The other fix is to create a real full screen, what depends on lightbox functionality.
@fernao "

The funny thing is, though, that full screen works fine for video, ideally it should be the same for images. Will test your commit now!

@agger-magenta
Copy link
Contributor Author

After introducing the change in config.js, I get this error, which originates in jquery.fancybox.pack.js when previewing images:

The requested content cannot be loaded.
Please try again later.

Preview of video etc still works fine.

agger-magenta pushed a commit that referenced this issue Mar 19, 2016
@agger-magenta
Copy link
Contributor Author

OK, there's no doubt it works much better now! The images are fetched in higher resolution and shown as big as possible within the browser, and that makes the slideshow much more impressive.

The "full-screen" option is confusing though, if you choose it the description is not displayed for the selected image, but when it comes to the next image in the slideshow, the description is back and thus the "full-screen" is forgotten.

@agger-magenta
Copy link
Contributor Author

Right now I think three things:

  • The new way of displaying images works a lot better.
  • It would work even better if the full-screen option was retained when switching to a new image.
  • However, true full-screen display as for videos might still be preferrable.

@sydro sydro removed their assignment Mar 19, 2016
@fernao
Copy link
Member

fernao commented Mar 19, 2016

Hey agger, thanks and sorry my mistake, late night commit!
May be we should update fancybox library and check that bug/behavior. Now i'm out of lap, but if someone want to test...

@20
Copy link
Member

20 commented Mar 22, 2016

Alo! Nice to see this enhancement :)

There is a bug viewing media's page/view.. Have a look on open.bocs.club:
http://open.bocs.club/#mocambos/solunto/media/e5d04877-e2ac-4726-ba10-b0cbd69c840b

It seems to be the link.. lacking dimension?
http://open.bocs.club/api/mocambos/solunto/media/e5d04877-e2ac-4726-ba10-b0cbd69c840b/00x300

Error:

Exception Value: tile cannot extend outside image

@fernao
Copy link
Member

fernao commented Mar 23, 2016

Hi there!

Probably supervisor was restarted but collectstatic not. API address changed, but the interface request didn't.
Look at the image request:
http://open.bocs.club/api/mocambos/solunto/media/e5d04877-e2ac-4726-ba10-b0cbd69c840b/00x300.jpg

@20 20 added the bug label Mar 23, 2016
@20
Copy link
Member

20 commented Mar 23, 2016

I've same problem in kalakuta.. Does it works overthere?

@agger-magenta
Copy link
Contributor Author

I just did an update-templates and supervisorctl restart bbx on hyndla and the problem is still there.

@fernao
Copy link
Member

fernao commented Mar 23, 2016

I got it... gonna send fix in a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants