-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full-screen doesn't work for images/slide show #195
Comments
I think that it isn't a bug, the "toggle size" button is dimmed because the image is already in original full size. |
I think it's not. E.g. in this page: http://baobaxia.modspil.dk/#mocambos/dpadua/bbx/search/ If you click on the first image, you'll get the lightbox view on only part of the screen. However, if you click on the medium (text below the image) and click "baixar", you'll see that the image is actually much larger. However, the lightbox is probably displaying a smaller version of the image, something between thumbnail and original size. Hmmm, this raises the issue whether there should be an option to go full-screen with the original image. But since the present behaviour seems to be by design, that means this ticket is not a bug, but a feature request. We should probably leave it for now. |
Speaking with Sydro we agreed to maximize image (as big as possible) in slideshow view.. He's working on that! |
Great! :-) |
Hi there, |
The above commit changes config.js.example, so, copy the new config to config.js in order to manually set image size. |
"The other fix is to create a real full screen, what depends on lightbox functionality. The funny thing is, though, that full screen works fine for video, ideally it should be the same for images. Will test your commit now! |
After introducing the change in config.js, I get this error, which originates in jquery.fancybox.pack.js when previewing images:
Preview of video etc still works fine. |
…e blank for backwards compatibility
OK, there's no doubt it works much better now! The images are fetched in higher resolution and shown as big as possible within the browser, and that makes the slideshow much more impressive. The "full-screen" option is confusing though, if you choose it the description is not displayed for the selected image, but when it comes to the next image in the slideshow, the description is back and thus the "full-screen" is forgotten. |
Right now I think three things:
|
Hey agger, thanks and sorry my mistake, late night commit! |
Alo! Nice to see this enhancement :) There is a bug viewing media's page/view.. Have a look on open.bocs.club: It seems to be the link.. lacking dimension? Error: Exception Value: tile cannot extend outside image |
Hi there! Probably supervisor was restarted but collectstatic not. API address changed, but the interface request didn't. |
I've same problem in kalakuta.. Does it works overthere? |
I just did an update-templates and supervisorctl restart bbx on hyndla and the problem is still there. |
I got it... gonna send fix in a while. |
When watching images in gallery view, there's a "toggle size" control, but it appears to be dimmed and doesn't work.
The text was updated successfully, but these errors were encountered: