Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring CSS file #114

Open
ctrlaltaf opened this issue Jun 11, 2024 · 2 comments
Open

Refactoring CSS file #114

ctrlaltaf opened this issue Jun 11, 2024 · 2 comments
Labels

Comments

@ctrlaltaf
Copy link
Collaborator

index.css is getting extremely large. All components use this file to define their CSS files. I think it would be beneficial to make independent CSS files for each Component i.e. Query.jsx has a corresponding Query.css.

@ctrlaltaf
Copy link
Collaborator Author

In addition to this, I think Query.jsx is the main focus of a refactor. Some of the follownig things are things to achieve in the refactor

  • Many state variables are used. Seeing which ones are redundant/could be combined into one state would be helpeful.
  • Many useEffects are used to signal when to render components and when to display information. Would be helpful to sketch out the lifecycle of components in query.jsx can be a starting point to see which are redundant/more or less important/needs refactoring
  • Components in query.jsx take many props. We can potentially determine what are necessary information to transfer between components and this would help the refactoring
  • Researching best practices for using many useState variables and useEffects
  • Research best practice for API fetch calls. I think we can refactor where and how we do fetch API calls to make it cleaner to understand and how information is passed through the websit

@oliverfanderson
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants