Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPU + Engine CPU Issue #10

Open
ashconnell opened this issue Jun 5, 2024 · 0 comments
Open

GPU + Engine CPU Issue #10

ashconnell opened this issue Jun 5, 2024 · 0 comments

Comments

@ashconnell
Copy link

Problem

It's not currently possible to have both:

  1. GPU panel, and
  2. CPU panel that tracks full engine ticks/updates (it only tracks render time)

The function init(renderer) is the only way to get the GPU panel, but this also patches three js to call begin() and end() automatically on each render call.

Most engines have their own tick/update cycle that updates systems etc as well as calling render.

Proposal

Would you accept a PR that modifies init(renderer) to become init(renderer, patch = true) to allow opting out of the three js patch?

This would allow us to have the GPU panel and still be able to manually call begin() and end() at the engine level, instead of just for rendering.

Any other suggestions welcome, i'll happily make a PR.

@ashconnell ashconnell changed the title init behavior issue GPU + Engine CPU Issue Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant