Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create conversion invoices fails on Base, BSC, Optimism, and Gnosis #1574

Open
2 tasks
MantisClone opened this issue Jan 23, 2025 · 2 comments
Open
2 tasks
Assignees

Comments

@MantisClone
Copy link
Member

MantisClone commented Jan 23, 2025

Problem

Create Request Form fails to create conversion invoices on several chains:

  1. Base
  2. BSC
  3. Optimism
  4. Gnosis (XDAI)
  5. Possibly others...

Image
Image
Image

Non-problems

  • Regular invoices are created successfully - in which the Invoice Currency is crypto, not fiat.
  • Conversion invoices on Mainnet, Sepolia, and Polygon are created successfully, including both USD and EURO invoice currencies.

Solution

  • Test creating conversion invoices with all invoice currencies, payment chains, and payment currencies. Document test results.
  • Fix the bug
@MantisClone MantisClone changed the title Create Request Form fails to create conversion invoices on Base Create Request Form fails to create conversion invoices on Base, BSC, Optimism, and Gnosis Jan 23, 2025
@MantisClone MantisClone changed the title Create Request Form fails to create conversion invoices on Base, BSC, Optimism, and Gnosis Create Conversion invoices fails on Base, BSC, Optimism, and Gnosis Jan 23, 2025
@MantisClone MantisClone changed the title Create Conversion invoices fails on Base, BSC, Optimism, and Gnosis Create conversion invoices fails on Base, BSC, Optimism, and Gnosis Jan 23, 2025
@MantisClone MantisClone moved this from 🆕 New to 🔖 Sprint Backlog in Request Network Tech Backlog Jan 24, 2025
@sstefdev sstefdev moved this from 🔖 Sprint Backlog to 🏗 In Progress in Request Network Tech Backlog Feb 3, 2025
@MantisClone
Copy link
Member Author

Bandaid Solution: We removed the failing currencies in RequestNetwork/web-components#338

@MantisClone MantisClone transferred this issue from RequestNetwork/web-components Feb 25, 2025
@aimensahnoun
Copy link
Member

After investigation, the issue is due to the SDK having outdated conversion paths, which the currency manager checks.

So the issue is more SDK level rather than web components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏗 In Progress
Development

No branches or pull requests

3 participants