Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoice View fails to show Approval step in Payment Status Stepper if ERC20 approval is already granted #286

Open
MantisClone opened this issue Dec 19, 2024 · 1 comment

Comments

@MantisClone
Copy link
Member

MantisClone commented Dec 19, 2024

Problem

In the following video, I successfully pay an ERC20 request. However, the Approval step is absent from the payment status stepper.

Screencast.from.2024-12-19.00-32-58.webm

Solution

Ensure the Approval step is shown for all ERC20 requests, even if approval is already granted.

@MantisClone MantisClone converted this from a draft issue Dec 19, 2024
@sstefdev sstefdev added this to the Request Invoicing V3 milestone Dec 19, 2024
@sstefdev sstefdev self-assigned this Dec 19, 2024
@sstefdev sstefdev moved this from 🆕 New to 🔖 Sprint Backlog in Request Network Tech Backlog Dec 19, 2024
@MantisClone
Copy link
Member Author

We discussed this at the Tech Daily today. We decided to revisit this later after seeking user feedback.

It's possible that end-users prefer for the Approval step to be hidden if they've already granted it.

@MantisClone MantisClone moved this from 🔖 Sprint Backlog to 🎫 Backlog in Request Network Tech Backlog Dec 21, 2024
@MantisClone MantisClone removed this from the Request Invoicing V3 milestone Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🎫 Backlog
3 participants
@MantisClone @sstefdev and others