-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DateDiff rule #1462
Comments
Hi @gvieiragoulart! For a lot of use cases, you can use We also have the Maybe none of these fit what you need. If that's the case, let us know! Maybe draft an example of what this new validator would look like, what do you think? I think there are some good improvements that could be done over this area. If you want to work on it, you have my blessing! |
Hi there! I've started working on that rule, but due to a succession of major life events, I couldn't complete it for version 3.0. Is that what you were looking for, @gvieiragoulart? I'd be happy if anyone picks this up. |
Hey @henriquemoody @alganet ! If I could pick this task I would be really happy to try complete but it seems to me that you have done almost the entire work. What do you see that we have to improve? |
@gvieiragoulart, I don't really know what needs to improve. I know the tests are not passing, though. I won't be working on it any time soon, so if you want to pick it up, I'd be very happy with it! |
@gvieiragoulart I have some idea of what the next steps should be:
PHP also has the Let us know if you have any other questions, if anything doesn't make sense or require more clarification! |
I didn't find any Age validator on the code to reuse :( i think i missed something. |
Hey guys, I'm new in this project and I want to contribute by doing the DateDiff rule. But I noticed that we don't have any of differentiation rule.
What do you guys think about creating a new Core rule to help these differentiation rules?
The text was updated successfully, but these errors were encountered: