Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text input does not work when linking with SDL1 application #287

Closed
rzumer opened this issue Jan 27, 2019 · 2 comments
Closed

Text input does not work when linking with SDL1 application #287

rzumer opened this issue Jan 27, 2019 · 2 comments
Labels
help wanted Extra attention is needed low priority wontfix This will not be worked on

Comments

@rzumer
Copy link
Contributor

rzumer commented Jan 27, 2019

SDL1 will not handle text input automatically, which means that RAIntegration should provide its own event handlers for filling out text boxes, since events cannot be propagated from the client's end.

Keyboard event handlers are processed correctly, because navigation in the memory inspector, for example, works as expected.

While I have not found out anything about this issue in my research, I don't think this can be solved without change to RAIntegration, because the key events "belong" to it, i.e. I cannot intercept events on sub-windows with the client application.

@rzumer rzumer added the help wanted Extra attention is needed label Jan 27, 2019
@rzumer
Copy link
Contributor Author

rzumer commented Jan 27, 2019

Example client: RetroAchievements/oricutron@c8a9957 (use the RAOricutron.sln solution in the msvc\MSVC2017 directory).

I went back to SDL2 with the following commit, so be sure to pull from this specific one.

@Jamiras
Copy link
Member

Jamiras commented Aug 21, 2021

This is also a known issue for Allegro.

The message loop must call TranslateMessage to convert the WM_KEYDOWN messages to WM_CHAR messages. It's not something we can really do anything about in our code.

https://docs.microsoft.com/en-us/windows/win32/winmsg/using-messages-and-message-queues

If your application must obtain character input from the user, include the TranslateMessage function in the loop.

See also #758. A customized message loop is required to support tabbing between fields.

@Jamiras Jamiras closed this as completed Aug 21, 2021
@Jamiras Jamiras added the wontfix This will not be worked on label Aug 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed low priority wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants