Parsing speed improvements #4297
Open
+674
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aboedo
approved these changes
Oct 10, 2024
| return calendar | ||
| }() | ||
|
|
||
| private func toDateTryFastParsing() -> Date? { |
There was a problem hiding this comment.
dumb little nitpicks that you can totally disregard:
privatehere is redundant in that the extension is already private, we try not to repeat
We usually add line breaks after extension definitions and before they end
See examples in the style guide
Also, given that the method already returns an optional type, it feels like the try part is also redundant, I'd maybe go with toDateFastParse
Again, I don't feel particularly strongly about any of these tbh
There was a problem hiding this comment.
Done.
Please let me know if there is anything else you wish me to change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
purchases-androidand hybridsMotivation
I was scrolling through your code and saw
Which suggested that you care about performance of the parser. Since I wanted to improve my profiling skills here we are :)
Issue: #4006
Description
Improved performance of parsing receipt (which is mostly parsing of dates).
From profiler I saw that most of the time is spent in
ArraySlice.toDate().By removing
dateString = Stringand using system Calendar I was able to sigificently speed up the process.As fallback I left previous
ISO8601DateFormatter.default.dateExample results on iPhone 8
Datemach_absolute_timeCyclesINST_ALLL1D_TLB_MISSI've also added some additional test cases based on example receipts I was able to find through internet.