Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation folder does not exist error when browse installed button can be pressed #246

Open
Doomsdayrs opened this issue Jan 11, 2023 · 3 comments

Comments

@Doomsdayrs
Copy link

Describe the bug
During a fresh install, the "Browse Installed Files" button fails to function.

To Reproduce

  1. Install ThriveLauncher on a fresh installation
  2. Click Settings
  3. Click "Installed Versions"
  4. Click "Browse Installed Files"
  5. Notice error dialog "Folder not found"

Expected behavior
Folder opens up with no issue

Screenshots
image

Desktop (please complete the following information):

  • OS: Fedora
  • Launcher version: 2.0.3
@Doomsdayrs Doomsdayrs added the bug label Jan 11, 2023
@hhyyrylainen
Copy link
Member

Presumably that mentioned installed folder doesn't actually exist, right?
So the bug here is that the "browse installed files" button should not be clickable until a Thrive version has been installed.
That can probably be done with a pretty simple check when opening the settings (or when the install location has changed) to see if the target install folder exists or not and set a view model property that disables the button if it doesn't.

@hhyyrylainen hhyyrylainen changed the title Installation folder does not exist Installation folder does not exist error when browse installed button can be pressed Jan 11, 2023
@Doomsdayrs
Copy link
Author

Doomsdayrs commented Jan 11, 2023

Presumably that mentioned installed folder doesn't actually exist, right?

Yep

So the bug here is that the "browse installed files" button should not be clickable until a Thrive version has been installed.

I would disagree, the button should be clickable, the folder should be attempted to be created on launch. And warn the user if for whatever reason it can't be created.

That can probably be done with a pretty simple check when opening the settings (or when the install location has changed) to see if the target install folder exists or not

And attempt to create it, if creation fails a flag can be made to warn the user.

@hhyyrylainen
Copy link
Member

the folder should be attempted to be created on launch

I disagree. The launcher is used for example for Steam and itch.io seamless mode. The launcher should not create extraneous folders that may never be required by certain users.

It was even back in v1 that the install folder is only created the first time a Thrive version is attempted to be created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backburner
Development

No branches or pull requests

2 participants