Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected failure #4

Open
bvaughn opened this issue Sep 3, 2018 · 2 comments
Open

Unexpected failure #4

bvaughn opened this issue Sep 3, 2018 · 2 comments

Comments

@bvaughn
Copy link

bvaughn commented Sep 3, 2018

Cool project idea. πŸ˜„

I tried plugging it into one of my React libs this morning and noticed a failure that I didn't expect. I reduced to the following case in case you're interested:

βœ“ This passes:

var Foo;
Foo = function (props) {
};
export { Foo };

βœ“ This passes:

var Foo = function (props) {
};
Foo.defaultProps = {
};
export { Foo };

✘ This fails:

var Foo;
Foo = function (props) {
};
Foo.defaultProps = {
};
export { Foo };
@Andarist
Copy link

@bvaughn This is a rollup issue, I've just reported it over there - rollup/rollup#2562

Just a note - webpack & uglifyJS would be able to remove only the first one.

@y-nk
Copy link

y-nk commented Jun 2, 2020

same here with other (private) libraries...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants