Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify card removal #50

Closed
AlanOC91 opened this issue Aug 19, 2018 · 5 comments
Closed

Simplify card removal #50

AlanOC91 opened this issue Aug 19, 2018 · 5 comments
Labels
enhancement
Milestone
v5.0.0 - Renewal...

Comments

@AlanOC91
Copy link
Collaborator

Some users seem to be having issues with removing cards from the deck builder on devices like an iPad.

https://ygoprodeck.com/Forum/viewtopic.php?f=6&t=2241&p=2986#p2986

Possibly add a physical button to remove cards from the currently built deck?

Potentially:

  1. A button that removes the most recently added card.

or

  1. A "-" symbol next to the card name that removes them.

This may be useful for making it only show on specific devices:

http://detectmobilebrowsers.com/
@RillingDev RillingDev added this to the v4.13.0 - Chain Whirlwind milestone Aug 19, 2018
@RillingDev RillingDev mentioned this issue Feb 16, 2020
Closed
14 tasks
@RillingDev RillingDev changed the title Possibly add "remove" card button Add "remove" card button Apr 4, 2020
@RillingDev RillingDev changed the title Add "remove" card button Simplify card removal Jun 28, 2020
@RillingDev
Copy link
Owner

With the new Drag & Drop based approach this can be done by "spilling" a card while dragging.
There is an open bug that this relies on though: SortableJS/Vue.Draggable#827

@RillingDev
Copy link
Owner

Related: #79

@RillingDev
Copy link
Owner

Once SortableJS/Vue.Draggable#886 is merged, this can be fixed

@RillingDev
Copy link
Owner

RillingDev commented Sep 19, 2020 •
edited
Loading

Implemented workaround for 5.0.0, hoping for a 'real' fix for the final release

@RillingDev RillingDev mentioned this issue Nov 17, 2020
Open
@RillingDev
Copy link
Owner

Created follow-up, closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v5.0.0 - Renewal of the World
Development

No branches or pull requests
2 participants
@RillingDev @AlanOC91