-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[code insights] GitHub workflow status badges returns 404 when displayed in Readme #1207
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
We have noticed this has started happening as well using version |
To provide some more context of what it looks like is happening here: First the badge is attempted to be retrieved via API ( far as I can tell, this API endpoint is invalid), and an Authorization header is sent (Figure 1), but it fails because the endpoint is bad (Figure 2) Then the badge retrieval is attempted again not using the gh API, but rather just retrieving the image directly, and that fails (because there is no token / auth cookie maybe? (Figure 3). The repo in question in our is non-public. |
thanks for the detailed explanation @mhaley37! yea that's exactly what we're also facing. It would be nice if someone from the maintainers have a look |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This still occurs and quite annoying since it happens in almost every component we have. Would love for this to be handled or suppressed somehow. |
tagging some maintainers @Irma12 @kissmikijr for visibility |
I should clarify the 404 popup error is the annoying part imo. I personally have less concerns with the badges, etc not rendering properly. |
This is affecting us aswell, and is pretty annoying. Will look at contirbuting a PR for this |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Not stale |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Not stale |
hey @kissmikijr, any plans on fixing this? |
When using the code insights plugin, especially the readme component, the GitHub workflow status badges are always returned 404. The GitHub repo is an internal repo under a GitHub Organization.
The entire readme content gets rendered successfully except for the badges.
worthy to note that the backend csp img-src configs includes allowing content from github.com in the
app-config.yaml
Expected Behavior
The GitHub badges should be rendered correctly
Current Behavior
The readme card has some broken images and 404 is returned in the browser console
Steps to Reproduce
onboard a github repo to backstage that is of type internal.
the readme of this repo should have workflow status badges.
readme card badges doesn't get rendered.
Possible Solution
Context
Your Environment
currently using:
"@roadiehq/backstage-plugin-github-insights": "^2.3.21",
The text was updated successfully, but these errors were encountered: