Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workbench settings page feature toggles are unreadable except in dark mode. #484

Open
dubaaron opened this issue Aug 25, 2024 · 2 comments

Comments

@dubaaron
Copy link

Firstly, thanks to all who have worked creating and maintaining this extension -- it is very much appreciated. 🙏❤️

I don't know if anyone else has encountered this, but ever since I have installed this extension, whenever I go to the settings (unless I am in dark mode), it renders like this:

image

This occurs in Mac OS Roam desktop app, Android Roam mobile app, and on Edge browser (Chrome-based) on Mac OS.

In dark mode, it's OK; things are readable:
image

As a workaround, I can switch to dark mode if I want to toggle settings in Workbench, but it's a little burdensome, since I'm usually in Light Mode. Luckily, I don't have to toggle settings too often.

Just thought I'd see if anyone else had run into this, since it doesn't appear to be the case for any of my other Roam extensions.

Thanks very much -- Haribol

@dubaaron dubaaron changed the title Workbench settings page is unreadable except in dark mode. Workbench settings page feature toggles are unreadable except in dark mode. Aug 25, 2024
@mdroidian
Copy link
Collaborator

The issue is that we are using a Blueprint component (which are the standard roam components) which ships with dark styled table headers, so we were inlining the white color for the whole table. I've added a PR that will remove the inline styles and moved that to a css tag just for the table headers. This will make the table text readable in "light" mode, but the table headers will still be white.

I'm assuming you are using Roam Studio to set light/dark mode? This PR will allow them the ability to target these headers with css, as required.

image

@dubaaron
Copy link
Author

dubaaron commented Aug 25, 2024

Oh, I see. That makes sense. Yes, I am using Roam studio ... had had that turned on so long I'd forgotten that light/dark wasn't built in to Roam.

I tried turning off Roam studio, and now I see that the whole settings dialog stays in dark mode, for everything, haha. Ok. I guess that is the default behavior.

Thank you so much! Amazing that you fixed that already. Looking forward to your PR getting merged. : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants