Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CalcSlabEndPoints - Struct by reference needed #74

Open
Lanboost opened this issue Mar 23, 2018 · 1 comment
Open

CalcSlabEndPoints - Struct by reference needed #74

Lanboost opened this issue Mar 23, 2018 · 1 comment

Comments

@Lanboost
Copy link

If you use the vector definition by SharpNav.Geometry.Vector2 as a STRUCT, the method

class NavTile {
public static void CalcSlabEndPoints(Vector3 va, Vector3 vb, Vector2 bmin, Vector2 bmax, BoundarySide side)
}

The "output" bmin and bmax will always be "(0,0)" (outside of the function, this is because structs are passed by value)

https://stackoverflow.com/questions/9251608/are-structs-pass-by-value

Correct method should be

public static void CalcSlabEndPoints(Vector3 va, Vector3 vb, ref Vector2 bmin, ref Vector2 bmax, BoundarySide side)

This only affects creation of ConnectExtLinks between tiles to my knowledge

BR /Lan

@Robmaister
Copy link
Owner

Nice catch! I'll make this change when I get a chance, you're more than welcome to submit a PR as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants