-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review and update documentation #353
Comments
IIRC there was also one small typo recently in one of the docs where the doc said "install_prereqs.sh" but the file was just "install_prereqs" with no extension. It might be worth just doing a top-to-bottom read through and manual test of all examples, as a cleanup pass? |
That sounds like a good idea to me. @tyler-yankee was going to look into #266, would it make sense for him to do this task first? Both as a fresh pair of eyes and an intro to drake-external-examples. |
Yup, sounds good to me. Learning the current examples will help when making a new one. |
The |
The replacement tool would be |
@jwnimmer-tri: I'm trying to use meldis but the example in the demo, |
I'm happy to test it myself, and will let you know. It seems like it only exists in |
Right, it's the RobotLocomotion/drake#17649 train wreck. You can use this change for now to test: --- a/drake_cmake_installed/src/particles/uniformly_accelerated_particle.cc
+++ b/drake_cmake_installed/src/particles/uniformly_accelerated_particle.cc
@@ -91,7 +91,7 @@ std::unique_ptr<drake::systems::Context<double>>
UniformlyAcceleratedParticle::CreateContext(const double position,
const double velocity) const {
// Allocate context.
- auto context = this->AllocateContext();
+ auto context = this->CreateDefaultContext();
// Set continuous state.
drake::systems::VectorBase<double>& cstate =
context->get_mutable_continuous_state_vector(); That gets it working for me. (I also ran the example with I'll figure out the right next step for RobotLocomotion/drake#17649. We might end up deleting the particle from DEE so don't worry about fixing its docs yet. |
The main README needs to be updated to reflect the changes made in #309. Specifically, the advice "Scripts are provided for various CI instances in scripts/continuous_integration." is out-of-date. Other changes or clarifications may be needed as well.
The text was updated successfully, but these errors were encountered: