Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: Publish estimates as TwistWithCovarianceStamped to support estimators #7

Open
evan-palmer opened this issue Nov 13, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@evan-palmer
Copy link
Contributor

Feature Type

Adding new functionality to the project

Problem Description

The current implementation publishes the state information using the marine_msgs DVL message. This should continue to be used. However, this message is not accepted by various estimators supported by ROS.

Feature Description

Create a new second publisher, which publishes the velocity estimates transformed into the appropriate coordinate frame and as a TwistWithCovarianceStamped. This will ensure that estimators such as the robot_localization and fuse can interpret the message.

Alternative Solutions

I need to verify that the model used by fuse will accept this message type. The message type supported by fuse should be preferred over the robot_localization message type as the robot_localization package has been deprecated in favor of fuse.

Additional Context

No response

@evan-palmer evan-palmer added the enhancement New feature or request label Nov 13, 2024
@rakeshv24
Copy link

@evan-palmer is the expected coordinate frame for the estimators base_link or base_link_fsd?

@evan-palmer
Copy link
Contributor Author

This would be base_link

@rakeshv24
Copy link

Also, TwistWithCovariance is part of Odometry. Do we still need a separate publisher?

@evan-palmer
Copy link
Contributor Author

Oh I completely forgot that I added that. Maybe we should put the existing publisher on the odom_fsd frame and the new one on odom. We should double check how Fuse handles transforms. If it expects everything to be at the base frame, we might also want to think about a way to apply the adjoint transformation to that frame

@rakeshv24
Copy link

Makes sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants