Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: let from_kwargs accept higher-level names with full Option value #105

Open
schlichtanders opened this issue Oct 24, 2024 · 1 comment
Open

Feature Request: let from_kwargs accept higher-level names with full Option value #105

schlichtanders opened this issue Oct 24, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@schlichtanders
Copy link

currently, from_kwargs and related methods only accept leaf values. However sometimes it is handy to overwrite whole subset by specifying the entire Option value for the subtree.
@Roger-luo
Copy link
Owner

I don't quite remember why it didn't but it seems to be a good idea to me. Currently yeah it flattens all the keyword argument so that you can update things inner.

@Roger-luo Roger-luo added the enhancement New feature or request label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@schlichtanders @Roger-luo