Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add support for µs #12

Open
eval-exec opened this issue May 8, 2023 · 2 comments
Open

[Feature Request] Add support for µs #12

eval-exec opened this issue May 8, 2023 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@eval-exec
Copy link

µs is Microsecond

@RonniSkansing RonniSkansing added help wanted Extra attention is needed good first issue Good for newcomers labels May 8, 2023
@RonniSkansing
Copy link
Owner

RonniSkansing commented May 8, 2023

As us is supported, implementing µs should very easy from a string. But what if we go the other way.

Current behavior is a duration to string becomes us.

If we take a string that contains µs and convert it to a duration and back to a duration-string, it would become us, this seems like a unwanted or maybe unexpected effect.

Perhaps a way to deal with this, is to have a method that allows you to set if you want to output microseconds as us or ms.

What do you think? @eval-exec

@RonniSkansing RonniSkansing removed the good first issue Good for newcomers label May 8, 2023
@eval-exec
Copy link
Author

eval-exec commented May 9, 2023

Perhaps a way to deal with this, is to have a method that allows you to set if you want to output microseconds as us or µs.

Agree ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants