From 8826771ac35543b7b0d3ab5ecab5cb21701f0c45 Mon Sep 17 00:00:00 2001 From: Ross Brunton Date: Fri, 29 Mar 2024 13:34:05 +0000 Subject: [PATCH] [UR][Spec Constants] Improved handling of invalid/unsupported spec. constants Pre-commit MR for https://github.com/oneapi-src/unified-runtime/pull/1469 --- sycl/cmake/modules/FetchUnifiedRuntime.cmake | 26 ++++++++++++++------ 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a/sycl/cmake/modules/FetchUnifiedRuntime.cmake b/sycl/cmake/modules/FetchUnifiedRuntime.cmake index aa7bd830e4bc7..0496d93a9271b 100644 --- a/sycl/cmake/modules/FetchUnifiedRuntime.cmake +++ b/sycl/cmake/modules/FetchUnifiedRuntime.cmake @@ -116,14 +116,24 @@ if(SYCL_UR_USE_FETCH_CONTENT) CACHE PATH "Path to external '${name}' adapter source dir" FORCE) endfunction() - set(UNIFIED_RUNTIME_REPO "https://github.com/oneapi-src/unified-runtime.git") - # commit 22962057df1b9d538e08088a7b75d9d8e7c29f90 (HEAD, origin/main, origin/HEAD) - # Merge: e824ddc2 f0a1c433 - # Author: aarongreig - # Date: Fri Sep 27 16:54:04 2024 +0100 - # Merge pull request #2017 from nrspruit/new_sysman_init - # [L0] Use zesInit for SysMan API usage - set(UNIFIED_RUNTIME_TAG 22962057df1b9d538e08088a7b75d9d8e7c29f90) + set(UNIFIED_RUNTIME_REPO "https://github.com/RossBrunton/unified-runtime.git") + # commit f42a221861fc8e33b301fcc27df0cf048ec3a00c + # Author: Ross Brunton + # Date: Fri Mar 22 17:18:22 2024 +0000 + # [Spec Constants] Improved handling of invalid/unsupported spec. constants + # + # Two main changes to how `Kernel/ProgramSetSpecializationConstants` + # are handled: + # * They may now output either `INVALID_VALUE` or the new + # `INVALID_SPEC_ID` when the provided list is invalid. + # * The OpenCL and level 0 adapters now respond to + # `UR_DEVICE_INFO_KERNEL_SET_SPECIALIZATION_CONSTANTS` with `false` + # rather than erroring out. This fixes some tests that were + # incorrectly not being skipped. + # * `urKernelSetSpecializationConstants` now "implemented" (as a + # function that returns `UNSUPPORTED_FEATURE` for a number of + # adapters. + set(UNIFIED_RUNTIME_TAG f42a221861fc8e33b301fcc27df0cf048ec3a00c) set(UMF_BUILD_EXAMPLES OFF CACHE INTERNAL "EXAMPLES") # Due to the use of dependentloadflag and no installer for UMF and hwloc we need