From a0e9edd1e5700b0ebb3c858169380ce7dd8f1a79 Mon Sep 17 00:00:00 2001 From: Ross Brunton Date: Fri, 29 Mar 2024 13:34:05 +0000 Subject: [PATCH] [UR][Spec Constants] Improved handling of invalid/unsupported spec. constants Pre-commit MR for https://github.com/oneapi-src/unified-runtime/pull/1469 --- sycl/cmake/modules/FetchUnifiedRuntime.cmake | 27 ++++++++++++++------ 1 file changed, 19 insertions(+), 8 deletions(-) diff --git a/sycl/cmake/modules/FetchUnifiedRuntime.cmake b/sycl/cmake/modules/FetchUnifiedRuntime.cmake index 27a07c51098aa..8c174ca70bf5d 100644 --- a/sycl/cmake/modules/FetchUnifiedRuntime.cmake +++ b/sycl/cmake/modules/FetchUnifiedRuntime.cmake @@ -116,14 +116,25 @@ if(SYCL_UR_USE_FETCH_CONTENT) CACHE PATH "Path to external '${name}' adapter source dir" FORCE) endfunction() - set(UNIFIED_RUNTIME_REPO "https://github.com/oneapi-src/unified-runtime.git") - # commit 40a790fa5edaa635f49ce2e7342bfa5e5b359694 - # Merge: 2f67b38d 5e240cf8 - # Author: Omar Ahmed - # Date: Thu Aug 22 14:04:32 2024 +0100 - # Merge pull request #1995 from kswiecicki/refcount-clear - # Coverity fixes - set(UNIFIED_RUNTIME_TAG 40a790fa5edaa635f49ce2e7342bfa5e5b359694) + set(UNIFIED_RUNTIME_REPO "https://github.com/RossBrunton/unified-runtime.git") + # commit put-git-commit-hash-here + # Author: Ross Brunton + # Date: Fri Mar 22 17:18:22 2024 +0000 + # + # [Spec Constants] Improved handling of invalid/unsupported spec. constants + # + # Two main changes to how `Kernel/ProgramSetSpecializationConstants` + # are handled: + # * They may now output either `INVALID_VALUE` or the new + # `INVALID_SPEC_ID` when the provided list is invalid. + # * The OpenCL and level 0 adapters now respond to + # `UR_DEVICE_INFO_KERNEL_SET_SPECIALIZATION_CONSTANTS` with `false` + # rather than erroring out. This fixes some tests that were + # incorrectly not being skipped. + # * `urKernelSetSpecializationConstants` now "implemented" (as a + # function that returns `UNSUPPORTED_FEATURE` for a number of + # adapters. + set(UNIFIED_RUNTIME_TAG 2116a3fb792f15308084b2335a5153ee8a037cd1) set(UMF_BUILD_EXAMPLES OFF CACHE INTERNAL "EXAMPLES") # Due to the use of dependentloadflag and no installer for UMF and hwloc we need