Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate the performance of empty childDataFrame in FLWOR clauses #402

Open
CanBerker opened this issue Dec 3, 2019 · 0 comments
Open

Comments

@CanBerker
Copy link
Collaborator

@ghislainfourny Should the short circuit mentioned above (seen in OrderByClauseSparkIterator.java file) be added to other FLWOR clauses as well? It could save a bit of unnecessary computation and querying when operating on empty sequences. However this introduces an additional count() action which might be costly.

Here I think performance measurements would tell which is better. For an empty DF, the closures would not be called anyway, so that the count() action may be more costly than the gain. Maybe you could open an issue on this?

Originally posted by @ghislainfourny in #394 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants