Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BasePacketReader is badly-behaved if read_packet is not continually drained #28

Open
Ralith opened this issue Jan 28, 2022 · 2 comments
Open

BasePacketReader is badly-behaved if read_packet is not continually drained #28

Ralith opened this issue Jan 28, 2022 · 2 comments

Comments

@Ralith
Copy link

Ralith commented Jan 28, 2022

Pushing every page of a complete ogg file before attempting to read any packets will result in lost packets.
@est31
Copy link
Member

est31 commented Jan 29, 2022

Yeah there is only limited buffering. Maybe this should be pointed out.

@Ralith
Copy link
Author

Ralith commented Jan 29, 2022

It is very convenient when coupling push-based and pull-based interfaces to push all your data before trying to drain packets, so having undocumented breakage there is definitely an unpleasant surprise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Ralith @est31