Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataConverter is a subset of SamplesConverter #617

Open
dvdsk opened this issue Sep 16, 2024 · 2 comments
Open

DataConverter is a subset of SamplesConverter #617

dvdsk opened this issue Sep 16, 2024 · 2 comments
Labels
breaking Proposed change that would break the public API

Comments

@dvdsk
Copy link
Collaborator

dvdsk commented Sep 16, 2024

They both provide a way to lazily preform CpalSample::from_sample on all samples. SampleConverter implements Source DataConverter none.

We should remove DataConverter in favor of SampleConvertor.
@dvdsk dvdsk added the breaking Proposed change that would break the public API label Sep 16, 2024
@dvdsk dvdsk mentioned this issue Sep 16, 2024
Open
@PetrGlad
Copy link
Collaborator

PetrGlad commented Jan 5, 2025

SampleConverter? I cannot find it...
Besides, if we keep DataConverter I would rename it to SampleFormatConverter.

@dvdsk
Copy link
Collaborator Author

dvdsk commented Jan 5, 2025

SampleConverter? I cannot find it... Besides, if we keep DataConverter I would rename it to SampleFormatConverter.

typo by me, it is called SamplesConverter

@dvdsk dvdsk changed the title DataConverter is a subset of SampleConverter DataConverter is a subset of SamplesConverter Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking Proposed change that would break the public API
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PetrGlad @dvdsk