You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, as prescribed by Hast, "Note on computation of integer square roots" (https://github.com/RustCrypto/crypto-bigint/files/12600669/ct_sqrt.pdf), we are performing floor(log2(BITS)) + 2 iterations in Uint::sqrt() (to get x_n and x_{n+1}, where n = floor(log2(BITS)) + 1). But the tests indicate that it may be enough to only do floor(log2(BITS)) iterations. Need to check.
Currently, as prescribed by Hast, "Note on computation of integer square roots" (https://github.com/RustCrypto/crypto-bigint/files/12600669/ct_sqrt.pdf), we are performing
floor(log2(BITS)) + 2
iterations inUint::sqrt()
(to getx_n
andx_{n+1}
, wheren = floor(log2(BITS)) + 1
). But the tests indicate that it may be enough to only dofloor(log2(BITS))
iterations. Need to check.cc @HastD
The text was updated successfully, but these errors were encountered: