Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8 compatibility #108

Open
scottshipman opened this issue Oct 11, 2021 · 11 comments
Open

PHP 8 compatibility #108

scottshipman opened this issue Oct 11, 2021 · 11 comments

Comments

@scottshipman
Copy link

the packagist / composer instance tops out at php 7.

Are there plans to be compatible with php 8?

@jakegibs617
Copy link

agreed, this is a major showstopper for me.

rusticisoftware/tincan requires php ~5.5 || ^7.0.3 -> your php version (8.1.0) does not satisfy that requirement.

@Natshah
Copy link
Contributor

Natshah commented Jun 28, 2022

Hoping to have "php": "~5.5 || ^7 || ^8",

@chippyjacob1990
Copy link

Yes this is very urgent for the project to migrate to php8. See https://www.drupal.org/project/opigno_lms/issues/3269096

@bob-hinrichs
Copy link

Too bad this is still hanging! Php 7 is very soon to be done.

@mattpaz
Copy link

mattpaz commented Oct 5, 2022

@brianjmiller - any thoughts on getting this committed (or insight into why it isn't)?

@tc60045
Copy link

tc60045 commented Oct 21, 2022

any workarounds? fork time?

brianjmiller added a commit that referenced this issue Nov 2, 2022
@bob-hinrichs
Copy link

bob-hinrichs commented Nov 10, 2022

in 18 days php 7.4 support ends.

@tc60045
Copy link

tc60045 commented Nov 10, 2022

Thanks. I swapped horses, moving from Drupal / Opigno to Wordpress / Sensei LMS.

@hamletta
Copy link

If you're stuck, the devs behind Opigno, a Drupal-based LMS, forked this package to solve the immediate problem: https://github.com/opigno/TinCanPHP

@mattpaz
Copy link

mattpaz commented Jan 17, 2023

@alexrayu @spheresh

Does the willdurand/negotiation dependency need to be bumped from 2.3.1 to 3.1.0?

V3 added PHP 8 support.
https://github.com/willdurand/Negotiation/releases

@mattpaz
Copy link

mattpaz commented Feb 7, 2023

I noticed that #110 was committed, which is great.

But there still seems to be some work to do relative to PHP 8.1 support.
In addition to the willdurand/negotiation question, I observed at least one deprecated technique was in play:

Deprecated function: http_build_query(): 
Passing null to parameter #2 ($numeric_prefix) of type string is deprecated 
in TinCan\RemoteLRS->sendRequest() 

https://github.com/RusticiSoftware/TinCanPHP/blob/9758b3ec08653f7a49c8ab14ebd1f01557d89b78/src/RemoteLRS.php

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants