Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using a mock HTTP request object for RemoteLRS unit tests #70

Open
brianjmiller opened this issue Aug 22, 2016 · 1 comment
Open

Comments

@brianjmiller
Copy link
Member

Would be much easier to test the underlying LRS requirements if the HTTP object could be mocked such that we can make sure the various parts of it are setup and executed correctly.

@WillSkates
Copy link

Testing against an actual service is really benefitial here but your point still stands.

A good compromise would be if we could run the same test suite against multiple LRS implementations and mock the ones we don't have an endpoint to test against. For example Learning Locker as @johnpbloch pointed out in #47.

Have you seen Guzzle's stream handler? I wonder if it would be easier to use that instead of rearchitecting the HTTP logic that's already in the lib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants