Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems when using extended ASCII codes (above number 127) in S7Strings #436

Closed
ismdiego opened this issue Jun 16, 2022 · 1 comment
Closed

Comments

@ismdiego
Copy link
Contributor

The default Encoding.ASCII used in S7String to serialize and deserialize strings to/from byte array is not always valid in some situations where you want to use extended ASCII Code Pages, like the Windows 1252, or Iso-8859-1.

I have created a PR (#435) with a proposed workaround for this, allowing the user to change the Encoding used by S7String system-wide. It only modifies S7String class, and the behavior is exactly the same if the user does nothing.

@ismdiego ismdiego changed the title Problems when using extended ASCII codes (above number 127) ans S7Strings Problems when using extended ASCII codes (above number 127) in S7Strings Jun 16, 2022
@mycroes
Copy link
Member

mycroes commented Jun 17, 2022

Fixed in 0.14.0, thanks for the PR!

@mycroes mycroes closed this as completed Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants