Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@sap-cloud-sdk/mail-client: Allow OnPremise MAIL destinations without basic authentication so that no user and password is required #5136

Open
gregorwolf opened this issue Oct 30, 2024 · 2 comments
Labels
feature request Requests for new functionality prio: low

Comments

@gregorwolf
Copy link

Is your feature request related to a problem? Please describe.

OnPremise mail servers might not need any authentication. But with the check in mail-client/src/mail-client.ts#L82 it is currently mandatory to provice a user and password by setting the MAIL destination to the Authentication type BasicAuthentication and maintaining User and Password.

Describe the solution you'd like

At least for destination of Proxy Type OnPremise the @sap-cloud-sdk/mail-client should allow destinations where Authentication is set to NoAuthentication.

Describe alternatives you've considered

The configuration of the internal mailserver can't be changed quickly.

Impact / Priority

Affected development phase: Production

Impact: Impaired

Additional context

Same customer as in #5015 is impacted.

@gregorwolf
Copy link
Author

Hi @marikaner / @ZhongpinWang,

can one of you please review?

@ZhongpinWang
Copy link
Contributor

Hi @marikaner / @ZhongpinWang,

can one of you please review?

Hi @gregorwolf , sorry for the delay, and thanks a lot for your contribution. I left some comments in your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Requests for new functionality prio: low
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants