Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

display calendar legend #12403

Open
egorwow70 opened this issue Sep 11, 2024 · 5 comments · May be fixed by #12915
Open

display calendar legend #12403

egorwow70 opened this issue Sep 11, 2024 · 5 comments · May be fixed by #12915
Assignees
@alexhristov14
Labels
bug Something isn't working
Milestone
Sprint 143 - Febr...

Comments

@egorwow70
Copy link

egorwow70 commented Sep 11, 2024 •
edited by InnaAtanasova
Loading

Is this a bug, enhancement, or feature request?

bug

Describe your proposal.

Hello, fundamental-ngx team. We are implementing the app using angular and fundamental-ngx/core and have a requirement to display a date picker with special dates and legend displayed. As I can see, special dates can be displayed with current library functionality, but the legend is missing. Is it possible to fix it on the library side?

Legend should be supported by both fd-calendar and fd-date-picker from fundamental-ngx/core

As for the technical side, I think it will be easy for devs, who are using the lib, to configure that via those objects (SpecialDayRule), for example via new field - title or label or legendLabel (naming up to you):

image

I am not a designer, but this is an example what we need:
image

Sapui5 example - https://sapui5.hana.ondemand.com/#/entity/sap.ui.unified.Calendar/sample/sap.ui.unified.sample.CalendarSpecialDaysLegend

Can you handle that on the application side

No.

Which versions of Angular and Fundamental Library for Angular are affected? Please, specify the exact version. (If this is a feature request, use current version.)

  • "@fundamental-ngx/core": "0.49.0",
  • "@sap-theming/theming-base-content": "11.13.0",
  • "fundamental-styles": "0.34.0",
  • "@angular/core": "17.3.0",

Did you check the documentation and the API?

Yes.

Did you search for similar issues?

Yes
@egorwow70 egorwow70 changed the title [FEATURE REQUEST] display legend in fd-picker if special dates used [FEATURE REQUEST] display legend in fd-date-picker if special dates used Sep 11, 2024
@droshev
Copy link
Contributor

droshev commented Sep 11, 2024

@egorwow70 what you refer to ui5 is the calendar components, not the datepicker. We have the same for datepicker - https://fundamental-ngx.netlify.app/#/core/calendar

@egorwow70
Copy link
Author

egorwow70 commented Sep 11, 2024 •
edited
Loading

@droshev

Thanks for the reply, I assume, that the date-picker control uses calendar control according to the library repo source files -

fundamental-ngx/libs/core/date-picker/date-picker.component.html

Line 70 in a9d0906

<fd-calendar

And I don't find any legend configuration here, as well in the SpecialDayRule interface:
image

So, it seems it would be great to have it inside both calendar and date picker, because the second one uses the first one

@droshev
Copy link
Contributor

droshev commented Sep 11, 2024

@droshev

Thanks for the reply, I assume, that the date-picker control uses calendar control according to the library repo source files -

fundamental-ngx/libs/core/date-picker/date-picker.component.html

Line 70 in a9d0906

<fd-calendar

And I don't find any legend configuration here, as well in the SpecialDayRule interface: image

So, it seems it would be great to have it inside both calendar and date picker, because the second one uses the first one

Let me bring this with the designers first.

@droshev droshev changed the title [FEATURE REQUEST] display legend in fd-date-picker if special dates used display calendar legend Sep 13, 2024
@droshev droshev added the bug Something isn't working label Sep 13, 2024
@droshev
Copy link
Contributor

droshev commented Sep 13, 2024

@egorwow70 we have the feature for special days, we just need to display them in the calendar (respectively in datepicker and datetimepicker)

@droshev
Copy link
Contributor

droshev commented Oct 3, 2024

@alexhristov14 Can you check whether we need to implement this in styles first and then bring it in ngx?

@droshev droshev added this to the Sprint 139 - October 2024 milestone Oct 3, 2024
This was referenced Oct 17, 2024
Closed
Merged
This was referenced Jan 10, 2025
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexhristov14 alexhristov14

Labels
bug Something isn't working
Projects
None yet
Milestone
Sprint 143 - February 2025
4 participants
@droshev @InnaAtanasova @egorwow70 @alexhristov14