Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The fundamental NGX component does not provide any inputs on tooltips #12719

Open
AnushkaAG29 opened this issue Nov 13, 2024 · 3 comments · May be fixed by #12982
Open

The fundamental NGX component does not provide any inputs on tooltips #12719

AnushkaAG29 opened this issue Nov 13, 2024 · 3 comments · May be fixed by #12982
Assignees
Labels
accessibility use this label for any issue or enhancement related to screenreader/keyboard/etc support

Comments

@AnushkaAG29
Copy link

AnushkaAG29 commented Nov 13, 2024

Is this a bug, enhancement, or feature request?

Feature request

Describe your proposal.

The table components used from the NGX platform do not include tooltips for usage.

Can you handle that on the application side

--

Which versions of Angular and Fundamental Library for Angular are affected? Please, specify the exact version. (If this is a feature request, use current version.)

0.53.0

If this is a bug, please provide steps for reproducing it; the exact components you are using;

In the table, there are drop-downs inside rows. A tooltip is required for those drop-downs. But there is no code which includes tooltips here.

Please provide relevant source code (if applicable).

HTML code:

<fdp-table
#table
[dataSource]="source"
[childDataSource]="childSource"
[isTreeTable]="true"
selectionMode="multiple"
relationKey="children"
emptyTableMessage="No data found"
bodyHeight="300px"
[virtualScroll]="true"
[pageScrolling]="true"
[pageSize]="50"
[renderAhead]="50"
[pageScrollingThreshold]="80"
hasChildrenKey="hasChildren"
[expandOnInit]="true"

<fdp-table-toolbar title="Order Line Items" [hideItemCount]="false" [hideSearchInput]="true"> </fdp-table-toolbar>

<fdp-column
    name="name"
    key="name"
    label="Name"
    align="start"
    [sortable]="true"
    [filterable]="true"
    [dataType]="dataTypeEnum.STRING"
>
</fdp-column>

<fdp-column name="description" key="description" label="Description"> </fdp-column>

<fdp-column
    name="price"
    key="price.value"
    label="Price"
    align="end"
    [sortable]="true"
    [filterable]="true"
    [dataType]="dataTypeEnum.NUMBER"
>
</fdp-column>

<fdp-column
    name="status"
    key="status"
    label="Status"
    align="center"
    [sortable]="true"
    [filterable]="true"
    [dataType]="dataTypeEnum.STRING"
>
</fdp-column>

<fdp-table-p13-dialog [table]="table">

Please provide stackblitz example(s).

--

In case this is Accessibility related topic, did you consult with an accessibility expert? If not, please do so and share their recommendations.

Since the NGX component doesn't include tooltips, it violates the ACC standard and it needs to be fixed. (As said by the accessibility expert).

Did you check the documentation and the API?

Yes

Did you search for similar issues?

Yes

Is there anything else we should know?

https://sap.github.io/fundamental-ngx/#/platform/table/advanced

IMPORTANT: Please refrain from providing links or screenshots of SAP's internal information, as this project is open-source, and its contents are accessible to anyone.

@droshev droshev added the accessibility use this label for any issue or enhancement related to screenreader/keyboard/etc support label Nov 13, 2024
@mikerodonnell89
Copy link
Member

What "drop downs"? Can you give more specific details about what is missing from where, and what you'd like to see?

@AnastasiyaVavilava
Copy link

I have the same issue with table action buttons that don’t have tooltips (ex. arrows in clickable rows)
Screenshot 2024-11-26 at 12 53 18
Screenshot 2024-11-26 at 12 53 07

@AnushkaAG29
Copy link
Author

AnushkaAG29 commented Nov 28, 2024

Screenshot 2024-11-28 at 9 14 03 AM

Tooltips are needed here for these drop downs under the name column.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility use this label for any issue or enhancement related to screenreader/keyboard/etc support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants