From e7fb363281286ea38fc4d609a7f905a899b12cc9 Mon Sep 17 00:00:00 2001 From: Waldemar Mazurek Date: Mon, 23 Dec 2024 11:28:15 +0100 Subject: [PATCH 1/2] Fixes testCompatibility script (#4079) --- .../test-app/compound/wc-compound-container.cy.js | 14 ++++++++------ scripts/testCompatibility.sh | 2 +- test/e2e-client-api-test-app/package.json | 3 ++- 3 files changed, 11 insertions(+), 8 deletions(-) diff --git a/container/cypress/e2e/test-app/compound/wc-compound-container.cy.js b/container/cypress/e2e/test-app/compound/wc-compound-container.cy.js index efe5827644..0cc5b469cc 100644 --- a/container/cypress/e2e/test-app/compound/wc-compound-container.cy.js +++ b/container/cypress/e2e/test-app/compound/wc-compound-container.cy.js @@ -4,7 +4,12 @@ describe('Compound Container Tests', () => { let stub; beforeEach(() => { - cy.visit('http://localhost:8080/compound/compoundClientAPI.html'); + cy.visit('http://localhost:8080/compound/compoundClientAPI.html', { + onBeforeLoad(win) { + // Set up a spy on console.log + cy.stub(win.console, 'log').as('consoleLogSpy'); + } + }); stub = cy.stub(); }); @@ -250,6 +255,7 @@ describe('Compound Container Tests', () => { cy.hash().should('eq', '#openAsModal-wc'); }); }); + it('openAsDrawer webcomponent container', () => { cy.on('window:alert', stub); @@ -261,6 +267,7 @@ describe('Compound Container Tests', () => { cy.hash().should('eq', '#openAsDrawer-wc'); }); }); + it('openAsSplitview webcomponent container', () => { cy.on('window:alert', stub); @@ -276,11 +283,6 @@ describe('Compound Container Tests', () => { it('LuigiClient API publishEvent', () => { cy.on('window:alert', stub); - // Set up a spy on console.log - cy.window().then((win) => { - cy.spy(win.console, 'log').as('consoleLogSpy'); - }); - cy.get(containerSelector) .shadow() .contains('Publish event') diff --git a/scripts/testCompatibility.sh b/scripts/testCompatibility.sh index 120ef7257d..ab343908d4 100755 --- a/scripts/testCompatibility.sh +++ b/scripts/testCompatibility.sh @@ -261,7 +261,7 @@ verifyAndStartWebserver() { echoe "Stepping out" cd .. fi - if [ "${APP_FOLDERS[$i]}" != "/test/e2e-js-test-application" ]; then + if [ "${APP_FOLDERS[$i]}" != "/test/e2e-client-api-test-app" ] && [ "${APP_FOLDERS[$i]}" != "/test/e2e-js-test-application" ]; then runWebserver ${APP_PORTS[$i]} ${APP_PUBLIC_FOLDERS[$i]} ${APP_PATH_CHECK[$i]} else npm run dev & diff --git a/test/e2e-client-api-test-app/package.json b/test/e2e-client-api-test-app/package.json index c33445e944..5594af8b64 100644 --- a/test/e2e-client-api-test-app/package.json +++ b/test/e2e-client-api-test-app/package.json @@ -6,7 +6,8 @@ "scripts": { "copy": "rm -rf .\\public\\assets && mkdirp public/assets && cp node_modules/@luigi-project/container/bundle.js node_modules/@luigi-project/core/*.* node_modules/@luigi-project/client/*.js node_modules/@sap-theming/theming-base-content/content/Base/baseLib/sap_fiori_3/css_variables.css public/assets/", "serve": "live-server --port=3000 --mount=\"/node_modules\":\"./node_modules\" ./public --no-browser", - "start": "npm run copy && npm run serve", + "dev": "npm run copy && npm run serve", + "start": "npm run dev", "cypress-browser": "cypress open --e2e --browser chrome -c video=false", "cypress-headless": "cypress run -c video=false", "test": "echo \"Error: no test specified\" && exit 1" From 07cd3119117679dc7257ece71609d3415d418b9b Mon Sep 17 00:00:00 2001 From: Johannes Doberer Date: Mon, 23 Dec 2024 13:07:10 +0100 Subject: [PATCH 2/2] release v2.19.0 (#4091) --- CHANGELOG.md | 13 ++++++++++++- .../projects/client-support-angular/package.json | 2 +- .../testing-utilities/dist/package.json | 2 +- .../testing-utilities/package-lock.json | 4 ++-- .../testing-utilities/package.json | 2 +- client/public/package.json | 2 +- core/public/package.json | 2 +- core/public_root/package.json | 2 +- plugins/auth/public/auth-oauth2/package.json | 2 +- plugins/auth/public/auth-oidc/package.json | 2 +- 10 files changed, 22 insertions(+), 11 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 68ac4acb01..710443ec1c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -25,6 +25,16 @@ The lerna-changelog tool detects changes based on PR labels and maps them to sec --> +## [v2.19.0] (2024-12-23) + +#### :rocket: Added +* [#4078](https://github.com/SAP/luigi/pull/4078) Mitigation of potential backwards compatibility issue ([@hardl](https://github.com/hardl)) +* [#4077](https://github.com/SAP/luigi/pull/4077) getCurrentRoute in web component client api ([@hardl](https://github.com/hardl)) + + + + + ## [v2.18.3] (2024-12-17) #### :bug: Fixed @@ -1925,4 +1935,5 @@ The lerna-changelog tool detects changes based on PR labels and maps them to sec [v2.18.0]: https://github.com/SAP/luigi/compare/v2.17.0...v2.18.0 [v2.18.1]: https://github.com/SAP/luigi/compare/v2.18.0...v2.18.1 [v2.18.2]: https://github.com/SAP/luigi/compare/v2.18.1...v2.18.2 -[v2.18.3]: https://github.com/SAP/luigi/compare/v2.18.2...v2.18.3 \ No newline at end of file +[v2.18.3]: https://github.com/SAP/luigi/compare/v2.18.2...v2.18.3 +[v2.19.0]: https://github.com/SAP/luigi/compare/v2.18.3...v2.19.0 \ No newline at end of file diff --git a/client-frameworks-support/client-support-angular/projects/client-support-angular/package.json b/client-frameworks-support/client-support-angular/projects/client-support-angular/package.json index bac68178e7..4500024e59 100644 --- a/client-frameworks-support/client-support-angular/projects/client-support-angular/package.json +++ b/client-frameworks-support/client-support-angular/projects/client-support-angular/package.json @@ -22,5 +22,5 @@ "@luigi-project/client": "^2.0.0", "@luigi-project/testing-utilities": "^2.0.0" }, - "version": "2.18.3" + "version": "2.19.0" } \ No newline at end of file diff --git a/client-frameworks-support/testing-utilities/dist/package.json b/client-frameworks-support/testing-utilities/dist/package.json index 35101eee0a..03378155c5 100644 --- a/client-frameworks-support/testing-utilities/dist/package.json +++ b/client-frameworks-support/testing-utilities/dist/package.json @@ -19,7 +19,7 @@ "microfrontends", "testing" ], - "version": "2.18.3", + "version": "2.19.0", "engines": { "node": ">=18.19.1" } diff --git a/client-frameworks-support/testing-utilities/package-lock.json b/client-frameworks-support/testing-utilities/package-lock.json index f15cb6732a..56cb927d20 100644 --- a/client-frameworks-support/testing-utilities/package-lock.json +++ b/client-frameworks-support/testing-utilities/package-lock.json @@ -1,12 +1,12 @@ { "name": "@luigi-project/testing-utilities", - "version": "2.18.3", + "version": "2.19.0", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@luigi-project/testing-utilities", - "version": "2.18.3", + "version": "2.19.0", "license": "Apache-2.0", "devDependencies": { "ncp": "^2.0.0", diff --git a/client-frameworks-support/testing-utilities/package.json b/client-frameworks-support/testing-utilities/package.json index a9b693a164..fd7f668b1d 100644 --- a/client-frameworks-support/testing-utilities/package.json +++ b/client-frameworks-support/testing-utilities/package.json @@ -29,7 +29,7 @@ "microfrontends", "testing" ], - "version": "2.18.3", + "version": "2.19.0", "engines": { "node": ">=18.19.1" } diff --git a/client/public/package.json b/client/public/package.json index 544dc5bff7..05105c5752 100644 --- a/client/public/package.json +++ b/client/public/package.json @@ -17,5 +17,5 @@ "micro-frontends", "microfrontends" ], - "version": "2.18.3" + "version": "2.19.0" } \ No newline at end of file diff --git a/core/public/package.json b/core/public/package.json index f4b13cd579..46259f71f5 100644 --- a/core/public/package.json +++ b/core/public/package.json @@ -18,5 +18,5 @@ "micro-frontends", "microfrontends" ], - "version": "2.18.3" + "version": "2.19.0" } \ No newline at end of file diff --git a/core/public_root/package.json b/core/public_root/package.json index f4b13cd579..46259f71f5 100644 --- a/core/public_root/package.json +++ b/core/public_root/package.json @@ -18,5 +18,5 @@ "micro-frontends", "microfrontends" ], - "version": "2.18.3" + "version": "2.19.0" } \ No newline at end of file diff --git a/plugins/auth/public/auth-oauth2/package.json b/plugins/auth/public/auth-oauth2/package.json index 55c9083bd6..69041a08e6 100644 --- a/plugins/auth/public/auth-oauth2/package.json +++ b/plugins/auth/public/auth-oauth2/package.json @@ -16,5 +16,5 @@ "oauth2", "provider" ], - "version": "2.18.3" + "version": "2.19.0" } \ No newline at end of file diff --git a/plugins/auth/public/auth-oidc/package.json b/plugins/auth/public/auth-oidc/package.json index 4ae9636906..a41e87f67d 100644 --- a/plugins/auth/public/auth-oidc/package.json +++ b/plugins/auth/public/auth-oidc/package.json @@ -17,5 +17,5 @@ "openid connect", "provider" ], - "version": "2.18.3" + "version": "2.19.0" } \ No newline at end of file