Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passing null into constructor of EntityWrapper #354

Open
1 task done
s4heid opened this issue Jul 14, 2023 · 0 comments
Open
1 task done

Passing null into constructor of EntityWrapper #354

s4heid opened this issue Jul 14, 2023 · 0 comments
Labels
bug Something isn't working needs triage This issue needs to be investigated and confirmed as a valid

Comments

@s4heid
Copy link
Contributor

s4heid commented Jul 14, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

After #318, it is no longer possible to pass null, as an argument for the Entity into the constructor of the EntityWrapper. This is because we need to retrieve the created entity.

If this breaking change was not intended, I would like to propose adding a null check.

Expected Behavior

If the Entity is null, complete the promise and respond with No Content.

Steps To Reproduce

new EntityWrapper(ENTITY_NAME, (Entity) null)

Environment

- OS: ubuntu
- Java: 11
- NeonBee: 0.0.26

Relevant log output

No response

Anything else?

No response
@s4heid s4heid added bug Something isn't working needs triage This issue needs to be investigated and confirmed as a valid labels Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working needs triage This issue needs to be investigated and confirmed as a valid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@s4heid