-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory Benchmark #247
Comments
I had to disable the extension as it took 450% CPU (2,6 GHz 6-Core Intel Core i7) and over 1GB RAM for a very long time (not just for some seconds/minutes). |
Hi @matz3 Can you provide a reproducible scenario? |
I could only reproduce it with one quite large project (closed source; I will send you the details via e-mail). Seems to be related to Process is always Maybe this already gives you some hint where the problem comes from. Here are my VS Code details
|
Thanks for the information and initial investigation @matz3 👍 I suspect it may be related to this code snippet
It is possible we need to Is your use case a common scenario? would many UI5 projects include cyclic folder structures? |
I did a quick change trying to exclude
Can you try reproducing the issue again with this change (vsix below):
If you are interested in testing more pattern variations you can build the VSIX yourself in ~1min
|
Relevant code is here: #265 |
Still the same behavior with your attached vsix file.
I'm not sure about that. Usually this shouldn't happen, but in my case it's like this because of some local linking of npm packages, where I think too many links are created. Per package.json definition there is no cycle between those projects. Maybe it's also related to the number of
|
Perhaps the combination of cyclic folder structure and many manifet.json files is causing a bug with the VSCode
I suppose next steps in debugging would be:
I am however uncertain if we should actually examine this in more depth, as I am not sure if this is a real world scenario, e.g: I used to have performance/infinite loop issues with IntelliJ when I had my own scripts to link packages in a pseudo mono repo. But those have disappeared since I've started using lerna/yarn (in the same project)... |
Usually I've enabled all my extensions in all VS Code workspaces. |
How important is this to you? @matz3 Do you want to do a debug session together? I could guide you in making some
|
To me it's not a priority at all right now. |
The UI5 language server downloads a large amount of UI5 SDK data and retain it in memory.
It would be interesting to discover how much memory exactly is needed to run the UI5 Lang Server.
It would also be interesting to monitor regressions and memory consumption overtime.
The text was updated successfully, but these errors were encountered: