Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old G4 FHiCLs Incorreclty Change Electron Lifetime #515

Open
marcodeltutto opened this issue Sep 9, 2024 · 3 comments
Open

Old G4 FHiCLs Incorreclty Change Electron Lifetime #515

marcodeltutto opened this issue Sep 9, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@marcodeltutto
Copy link
Member

Some old G4 fcl files still use services.DetectorPropertiesService.Electronlifetime to change electron lifetime. This should be changed with the WC fcl parameter instead. Probably, we should remove these fcls and then create new ones when needed.

Example:
https://github.com/SBNSoftware/sbndcode/blob/39927777a4aa6747754dd3e2c991016dc7246804/sbndcode/JobConfigurations/standard/g4/g4_0.75ms_electron_lifetime.fcl#L3C1-L3C52

@marcodeltutto marcodeltutto added the bug Something isn't working label Sep 9, 2024
@absolution1
Copy link
Contributor

Hi @marcodeltutto
I think we need to pin wirecell and larsoft's electron lifetime to use a single value as there are ultimately multiple stages in the workflow that depend on the electron lifetime being set (some rely on wirecell and some rely on the detector properties service). Setting the value in a single place massively reduces failure modes

We've already done this in the dune far detector: https://github.com/DUNE/dunereco/blob/develop/dunereco/DUNEWireCell/wirecell_dune.fcl#L578

@marcodeltutto
Copy link
Member Author

Yes, totally agree @absolution1

@bear-is-asleep
Copy link
Contributor

Tagging PR #514 for reference to more discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants