Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Communication] Dropping MP3 #118

Closed
spessasus opened this issue Feb 24, 2025 · 1 comment
Closed

[Communication] Dropping MP3 #118

spessasus opened this issue Feb 24, 2025 · 1 comment
Assignees
Labels
communication Communication with others
Milestone

Comments

@spessasus
Copy link
Collaborator

As I and @Cacodemon345 agreed in #117, SFe should not support MP3. Here's why:

  • obsolete: opus does everything MP3 can, but better. What's the point of MP3?
  • proprietary formats are not cool.
  • saga mentioned Frankenstein mp3s and some decoder limitations requiring additional libraries. this points to the fact that MP3 can be very messy and Vorbis solves everything. I don't know the codecs all that well, but I think that they are right.
  • I do not want another bulky decoder doubling the size of my website and npm package. I'd also have to find one that's compatible with MIT.

So the new supported format list should be:

That should be enough. Uncompressed, lossless, two widely supported lossy formats.

@spessasus spessasus added the communication Communication with others label Feb 24, 2025
@spessasus spessasus added this to the 4.1 milestone Feb 24, 2025
@sylvia-leaf
Copy link
Collaborator

This has been solved in update 6. Support for wav in container is shown using these flags:

  • 03:00 bit 1 set
  • 03:01 bits 1-3 clear

This says "sfSampleType bit 4 is in use, but no compression formats are used."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
communication Communication with others
Projects
Status: Done
Development

No branches or pull requests

2 participants