Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Feature flag comparison #10

Open
sylvia-leaf opened this issue Feb 15, 2025 · 0 comments
Open

[FEATURE REQUEST] Feature flag comparison #10

sylvia-leaf opened this issue Feb 15, 2025 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@sylvia-leaf
Copy link

*Is your feature request related to a problem? Please describe. If not, remove this field.
Now that the ISFe chunk is being parsed by the reference implementation, we need to implement logic for the feature flags system to allow the implementation to reject banks that use features that are not supported by the bank.

Is your feature related to the sound library or the app/website?
App/website

Describe the solution you'd like
Add a function that takes a list of supported features, compares this list with the feature flags read in the flag sub-chunk and ensures that all features are supported.

Describe alternatives you've considered
Just read the feature flags, but not enforce them. However, this means that the output is not always specified in the specification, meaning that the reference implementation would be unsuitable as a reference and thus not fit for purpose.

Additional context
SpessaSynth does not currently support all SF2.04 features (24-bit and NRPN are not supported). However, because the reference SFe bank does not use these flags, we would for now set these flags as unsupported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

1 participant