SonarQube updates

RateAppSource/RateController/Classes/UDPcomm.cs

@@ -44,7 +44,7 @@ public string NetworkEP
             set
             {
                 string[] data;
-                if (IPAddress.TryParse(value, out IPAddress IP))
+                if (IPAddress.TryParse(value, out _))
                 {
                     data = value.Split('.');
                     cNetworkEP = IPAddress.Parse(data[0] + "." + data[1] + "." + data[2] + ".255");

RateAppSource/RateController/Classes/clsAlarm.cs

@@ -28,8 +28,7 @@ public void CheckAlarms()
 
             if (cRateAlarm )
             {
-                cMessage = "Alarm";
-                if (cRateAlarm) cMessage = "Rate  " + cMessage;
+                cMessage = "Rate Alarm";
                 cAlarmButton.Text = cMessage;
 
                 if (cSilenceAlarm)

RateAppSource/RateController/Classes/clsProduct.cs

@@ -27,7 +27,6 @@ public class clsProduct
         private int cCountsRev;
         private bool cEnabled = true;
         private bool cEnableProdDensity = false;
-        private bool cEraseAccumulatedUnits = false;
         private bool cFanOn;
         private double cHectaresPerMinute;
         private double cHours1;
@@ -189,14 +188,7 @@ public bool Enabled
         public bool EnableProdDensity
         { get { return cEnableProdDensity; } set { cEnableProdDensity = value; } }
 
-        public bool EraseAccumulatedUnits
-        {
-            get { return cEraseAccumulatedUnits; }
-            set
-            {
-                cEraseAccumulatedUnits = value;
-            }
-        }
+        public bool EraseAccumulatedUnits { get; set; }
 
         public bool FanOn
         {

RateAppSource/RateController/PGNs/PGN32296.cs

@@ -14,7 +14,6 @@ public class PGN32296
         private const byte HeaderHi = 126;
         private const byte HeaderLo = 40;
         private readonly FormStart mf;
-        private byte cProductID;
         private double[] cValue = new double[4];
 
         public PGN32296(FormStart CalledFrom)
@@ -24,6 +23,7 @@ public PGN32296(FormStart CalledFrom)
 
         public bool ParseStringData(string Sentence)
         {
+            byte cProductID;
             bool Result = false;
             try
             {

RateAppSource/RateController/PGNs/PGN32401.cs

@@ -59,7 +59,7 @@ public PGN32401(FormStart CalledFrom)
             GoodPinsLast = new bool[mf.MaxModules];
         }
 
-        public event EventHandler<PinStatusArgs> PinStatusChanged;
+        public event EventHandler<PinStatusEventArgs> PinStatusChanged;
 
         public bool Connected(int Module)
         {
@@ -172,7 +172,7 @@ public void UpdateActivity()
                     }
                     mf.Tls.WriteActivityLog(Mes, false, true);
 
-                    PinStatusArgs args = new PinStatusArgs();
+                    PinStatusEventArgs args = new PinStatusEventArgs();
                     args.GoodPins = cGoodPins[i];
                     args.Module = i;
                     PinStatusChanged?.Invoke(this, args);
@@ -200,7 +200,7 @@ public bool WorkSwitchOn()
             return Result;
         }
 
-        public class PinStatusArgs : EventArgs
+        public class PinStatusEventArgs : EventArgs
         {
             public bool GoodPins { get; set; }
             public int Module { get; set; }

RateAppSource/RateController/frmModuleConfig.cs

@@ -56,7 +56,7 @@ public frmModuleConfig(FormStart Main)
             }
         }
 
-        private void ArduinoModule_PinStatusChanged(object sender, PGN32401.PinStatusArgs e)
+        private void ArduinoModule_PinStatusChanged(object sender, PGN32401.PinStatusEventArgs e)
         {
             if (!e.GoodPins) mf.Tls.ShowHelp("Pin configuration for Module" + e.Module.ToString() + " not correct. Using default values.");
         }

RateAppSource/RateController/frmOptions.cs

@@ -609,12 +609,6 @@ private void groupBox1_Paint(object sender, PaintEventArgs e)
             mf.Tls.DrawGroupBox(box, e.Graphics, this.BackColor, Color.Black, Color.Blue);
         }
 
-        private void groupBox2_Paint(object sender, PaintEventArgs e)
-        {
-            GroupBox box = sender as GroupBox;
-            mf.Tls.DrawGroupBox(box, e.Graphics, this.BackColor, Color.Black, Color.Blue);
-        }
-
         private void tbPressureCal_Enter(object sender, EventArgs e)
         {
             double tempD;