Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MinGW build failure #41

Open
woollybah opened this issue Aug 2, 2018 · 1 comment
Open

MinGW build failure #41

woollybah opened this issue Aug 2, 2018 · 1 comment
Assignees

Comments

@woollybah
Copy link

woollybah commented Aug 2, 2018

Platform: Win32, x64, MinGW 7.2

The MinGW build fails when it defines TCHAR, with an error in winnt.h...

#ifdef _MSC_VER
#include <tchar.h>
#else
#ifndef TCHAR
#define TCHAR char
#endif

suggestion include

#if defined(_MSC_VER) || defined(__MINGW32__)

or

#ifdef _WIN32

Thanks!

@Luke1410
Copy link
Member

Luke1410 commented Aug 6, 2018

Thanks for the report.

Please note that we don't test / officially support MinGW atm (which is something we've got on our mid term roadmap - internal case number: SLNET-237). However, the suggested change obviously won't hurt and if it helps you, I'll apply the change right away to master.

Due to lack of other means to contact you, posting this here in the comment directly:
To be legal wise on the safe side, we'd kindly ask you to accept our CLA: https://github.com/SLikeSoft/SLikeNet/blob/master/.github/CONTRIBUTING.md .
Best send a short mail to the address specified there. Alternatively you can also simply reply here by comment. Also let us know whether we'd add a corresponding entry in the acknowledgement section for you.

@Luke1410 Luke1410 self-assigned this Aug 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants