Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make column store report percentages ignore nulls #187

Open
tznind opened this issue Sep 1, 2022 · 0 comments
Open

Make column store report percentages ignore nulls #187

tznind opened this issue Sep 1, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@tznind
Copy link
Contributor

tznind commented Sep 1, 2022 •
edited
Loading

I think this would be breaking change as FailureReport base class is only passed the Failure objects and a count of the rows done. It is never passed the actual values being validated.

Would need to track nullability in IsIdentifiableAbstractRunner or pass values to reports
@tznind tznind added the enhancement New feature or request label Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tznind