Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single command to add a new modality to a complex imaging load #148

Open
tznind opened this issue Jun 23, 2021 · 2 comments
Open

Single command to add a new modality to a complex imaging load #148

tznind opened this issue Jun 23, 2021 · 2 comments

Comments

@tznind
Copy link
Contributor

tznind commented Jun 23, 2021

Adding a modality to an existing load is complex especially when it includes bespoke components like

  • Distincter
  • Coalescer
  • Isolation

Having a single command that took a load and made sensible decisions about where to create the tables (same place as the other tables in the load) and the updates needed to arguments in the load modules to include references to the new tables where appropriate would be good e.g.:

 ./rdmp cmd AddModality MR_ LoadMetadata:1
@tznind
Copy link
Contributor Author

tznind commented Jul 20, 2021

Work has begin on this on branch cmd-add-modality @rkm. Should be ready in a week or so.

@rkm
Copy link
Member

rkm commented Jul 21, 2021

Thanks Thomas.

Not sure if this is a separate issue, but could we specify default column types/sizes? I've just resized ProcedureCodeSequence_CodeValue on all the US_Series* tables to varchar(100) to match the other tables, since the DLE was crashing on this. It would be great if we didn't have to manually apply this when adding new modalities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants