Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dicom_redact.py - does not redact all frames of all overlays when frame=overlay=-1 #19

Open
howff opened this issue May 5, 2023 · 1 comment

Comments

@howff
Copy link
Collaborator

howff commented May 5, 2023

When using the deid recipe rules to redact rectangles we don't know the specific frame/overlay, so we have to redact all frames and all overlays and all frames in overlays. But the code for finding out how many frames an overlay has is too complex so it's been left in the dicomimage.py library and not duplicated in dicom_redact.py, thus we only redact the first frame in each overlay. See the deduplication issue #18

@howff
Copy link
Collaborator Author

howff commented May 11, 2023

Mostly resolved with this commit 775664d

However, one remaining edge case is multiple frames within an overlay (very rare!), only the first frame in each overlay is redacted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant