From 3eebb89ad37f591011a81db481d8dcee74e64c45 Mon Sep 17 00:00:00 2001 From: Kuan-Wei Chiu Date: Fri, 1 Mar 2024 22:31:50 +0800 Subject: [PATCH 1/5] test: remove TODO comment and throwing unimplement error --- lab1/main_test.js | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/lab1/main_test.js b/lab1/main_test.js index 74a716b4..1a0b677e 100644 --- a/lab1/main_test.js +++ b/lab1/main_test.js @@ -3,21 +3,17 @@ const assert = require('assert'); const { MyClass, Student } = require('./main'); test("Test MyClass's addStudent", () => { - // TODO - throw new Error("Test not implemented"); + }); test("Test MyClass's getStudentById", () => { - // TODO - throw new Error("Test not implemented"); + }); test("Test Student's setName", () => { - // TODO - throw new Error("Test not implemented"); + }); test("Test Student's getName", () => { - // TODO - throw new Error("Test not implemented"); + }); \ No newline at end of file From 15a9294d14d547eba05d6f4b60498e8a49a79f19 Mon Sep 17 00:00:00 2001 From: Kuan-Wei Chiu Date: Fri, 1 Mar 2024 22:32:42 +0800 Subject: [PATCH 2/5] test: add Student's setName test --- lab1/main_test.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lab1/main_test.js b/lab1/main_test.js index 1a0b677e..f29833a2 100644 --- a/lab1/main_test.js +++ b/lab1/main_test.js @@ -11,7 +11,11 @@ test("Test MyClass's getStudentById", () => { }); test("Test Student's setName", () => { - + let student = new Student(); + student.setName("John"); + assert.strictEqual(student.name, "John"); + student.setName(123); + assert.strictEqual(student.name, "John"); }); test("Test Student's getName", () => { From 4c3714f7d3fbfb698be06e2fed1f2a87d4186706 Mon Sep 17 00:00:00 2001 From: Kuan-Wei Chiu Date: Fri, 1 Mar 2024 22:33:10 +0800 Subject: [PATCH 3/5] test: add Student's getName test --- lab1/main_test.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lab1/main_test.js b/lab1/main_test.js index f29833a2..6c989ed5 100644 --- a/lab1/main_test.js +++ b/lab1/main_test.js @@ -19,5 +19,8 @@ test("Test Student's setName", () => { }); test("Test Student's getName", () => { - + let student = new Student(); + assert.strictEqual(student.getName(), ""); + student.setName("John"); + assert.strictEqual(student.getName(), "John"); }); \ No newline at end of file From e4f621100a5b60b51310b3d5578bcf96507fd6b9 Mon Sep 17 00:00:00 2001 From: Kuan-Wei Chiu Date: Fri, 1 Mar 2024 22:33:33 +0800 Subject: [PATCH 4/5] test: add MyClass's addStudent test --- lab1/main_test.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lab1/main_test.js b/lab1/main_test.js index 6c989ed5..b48eda6b 100644 --- a/lab1/main_test.js +++ b/lab1/main_test.js @@ -3,7 +3,10 @@ const assert = require('assert'); const { MyClass, Student } = require('./main'); test("Test MyClass's addStudent", () => { - + let class1 = new MyClass(); + assert.strictEqual(class1.addStudent(123), -1); + let student = new Student(); + assert.strictEqual(class1.addStudent(student), 0); }); test("Test MyClass's getStudentById", () => { From 243e7955cb79fab8d6d6ce467dae78cdbc2286a5 Mon Sep 17 00:00:00 2001 From: Kuan-Wei Chiu Date: Fri, 1 Mar 2024 22:33:55 +0800 Subject: [PATCH 5/5] test: add MyClass's getStudentById test --- lab1/main_test.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lab1/main_test.js b/lab1/main_test.js index b48eda6b..7ba38ad8 100644 --- a/lab1/main_test.js +++ b/lab1/main_test.js @@ -10,7 +10,11 @@ test("Test MyClass's addStudent", () => { }); test("Test MyClass's getStudentById", () => { - + let class1 = new MyClass(); + let student = new Student(); + class1.addStudent(student); + assert.strictEqual(class1.getStudentById(-1), null); + assert.strictEqual(class1.getStudentById(0), student); }); test("Test Student's setName", () => {