Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centre footer in mobile View #88

Open
djdiptayan1 opened this issue Oct 18, 2024 · 14 comments · May be fixed by #111
Open

Centre footer in mobile View #88

djdiptayan1 opened this issue Oct 18, 2024 · 14 comments · May be fixed by #111
Assignees
Labels

Comments

@djdiptayan1
Copy link
Member

The footer content needs to be centered and justified. the social buttons and "Created By GCSRM Team 🐐" needs to be centered.
Also center the logo and adderss

Screenshot 2024-10-18 at 11 35 01 PM
@Sameer01-01
Copy link

I can fix this issue.

before

Screenshot 2024-10-23 120842

After

Screenshot 2024-10-23 120911

@djdiptayan1
Copy link
Member Author

djdiptayan1 commented Oct 23, 2024

Sure. text in discord. team lead will assign it to you @Sameer01-01

@UtkarshJaiswal1406
Copy link
Contributor

@Sameer01-01 keep in mind that its still off center from the page's perspective because the 'scroll to top' button is messing with the alignment on the right side.
also that white line at the bottom shouldnt be there.
Keep these issues in mind while working on this

@Sameer01-01
Copy link

Sure. text in discord. team lead will assign it to you @Sameer01-01

ok..should i text in the technical discussion channel or somewhere else??

@UtkarshJaiswal1406
Copy link
Contributor

UtkarshJaiswal1406 commented Oct 23, 2024

ok..should i text in the technical discussion channel or somewhere else??

technical discussion

@Sameer01-01
Copy link

Sameer01-01 commented Oct 23, 2024

@Sameer01-01 keep in mind that its still off center from the page's perspective because the 'scroll to top' button is messing with the alignment on the right side. also that white line at the bottom shouldnt be there. Keep these issues in mind while working on this

ok bhiaya...the white line is just visible in chrome when i view it in different phones using chrome dev tools, it won't be there in the deployed website.

the scroll button is fixed in the webpage...should i move the footer a little upwards so that it will be centered and also it wont look odd with respect to the scroll button??

@UtkarshJaiswal1406
Copy link
Contributor

ok bhiaya...the white line is just visible in chrome when i view it in different phones using chrome dev tools, it won't be there in the deployed website.

the scroll button is fixed in the webpage...should i move the footer a little upwards so that it will be centered and also it wont look odd with respect to the scroll button??

scroll button is messing with the horizontal alignment. I don't see how moving the footer up would help. Try something else

@UtkarshJaiswal1406
Copy link
Contributor

UtkarshJaiswal1406 commented Oct 23, 2024

I'm assigning this issue to you. Create a new branch and experiment

Add me, diptayan and anushka as the reviewers whenever your decide to open a PR

@Sameer01-01
Copy link

Sameer01-01 commented Oct 23, 2024

I'm assigning this issue to you. Create a new branch and experiment

ok bhaiya..i will do that.

@Sameer01-01
Copy link

Sameer01-01 commented Oct 23, 2024

i have done a change...the scroll button will be visible till contact us form and after that it will be hidden...by doing this the footer will be centered...is this ok??

footer part

Screenshot 2024-10-23 162730

contact us part

Screenshot 2024-10-23 162744

@djdiptayan1
Copy link
Member Author

check the footer part once, its not properly centered. rest is good in my opinion.

@Sameer01-01
Copy link

check the footer part once, its not properly centered. rest is good in my opinion.

ok..is this fine??

Screenshot 2024-10-23 170051

@djdiptayan1
Copy link
Member Author

desktop view should not be affected.

@UtkarshJaiswal1406 UtkarshJaiswal1406 linked a pull request Oct 23, 2024 that will close this issue
@Sameer01-01
Copy link

this is the desktop view

Screenshot 2024-10-23 195253

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants