Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Mobile | Fix iOS border animation #1106

Merged
merged 3 commits into from
Oct 22, 2024
Merged

Conversation

zacharykeeping
Copy link
Member

@zacharykeeping zacharykeeping commented Oct 18, 2024

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

Closes #1105

  1. What was changed?

This border animation is occurring due to a MAUI bug. See here for the issue and the source of this workaround:

dotnet/maui#18204

This change disables animations on borders on iOS so we stop having this weird animation. It looks like this issue might be resolved when version 9.0.0 comes around.

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-10-18.at.14.56.22.mp4

✅ Figure: Weird border animation is no longer occurring

  1. Did you do pair or mob programming?

No

Copy link
Contributor

@matt-goldman-ssw matt-goldman-ssw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zacharykeeping zacharykeeping merged commit f10b6bf into main Oct 22, 2024
6 checks passed
@zacharykeeping zacharykeeping deleted the fix-ios-border-animation branch October 22, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Mobile | Border animation issues on iOS
2 participants