Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Scan | Mobile app should only scan for SSW Rewards QR codes #1176

Open
4 tasks
jernejk opened this issue Jan 30, 2025 · 1 comment · Fixed by #1177
Open
4 tasks

✨ Scan | Mobile app should only scan for SSW Rewards QR codes #1176

jernejk opened this issue Jan 30, 2025 · 1 comment · Fixed by #1177
Assignees
@jernejk
Labels
feature New functionality.

Comments

@jernejk
Copy link
Member

jernejk commented Jan 30, 2025

Cc: @vladislav-kir, @adamcogan, @wicksipedia

Hi @sethdaily,

Describe the Bug

At NDC London, we got feedback that scanning for QR codes is too sensitive. We can fix this in part by only responding to SSW Rewards codes.

To Reproduce

Steps to reproduce the behavior:

  1. Go to mobile app
  2. Start scanning
  3. Scan random QR code
  4. See error

Expected Behavior

Tasks

  • Investigate
  • Allow scanning only QR codes starting with "sswrewards://"

Acceptance Criteria

Environment

  • Device: iPhone, iPad and Android
  • OS: iOS and Android

Screenshots

Image

Thanks!
@jernejk jernejk added the feature New functionality. label Jan 30, 2025
@jernejk jernejk self-assigned this Jan 30, 2025
@jernejk jernejk mentioned this issue Jan 30, 2025
Merged
@jernejk jernejk linked a pull request Jan 30, 2025 that will close this issue
✨ Reacts only to QR codes that contains "sswrewards://" #1177
Merged
@jernejk jernejk reopened this Jan 30, 2025
@jernejk
Copy link
Member Author

jernejk commented Jan 30, 2025

Not yet deployed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jernejk jernejk

Labels
feature New functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

✨ Reacts only to QR codes that contains "sswrewards://" SSWConsulting/SSW.Rewards.Mobile
1 participant
@jernejk