code structure cleanup

[michielbdejong]

I just noticed there is some code still in the createFederatedShare method of federatedgroups/lib/FederatedFileSharing/FederatedShareProvider that should be in federatedgroups/lib/FederatedGroupsShareProvider
We need to make a map of which parts of the existing core apps code we are replacing with a user-and-groups-capable variant, and which parts we are doubling up with an additional groups-capable child class. For the FederatedShareProvider we now have federatedgroups/lib/FederatedGroupsShareProvider so federatedgroups/lib/FederatedFileSharing/FederatedShareProvider should probably not even exist, right?

[michielbdejong]

For the FederatedShareProvider it's probably best if we copy it, make some private methods protected, and then inherit from it for the FederatedGroupsShareProvider.

[michielbdejong]

One thing we could do is, for each file we copied&modified from core apps, do a diff against the unchanged version of the file, so we can see exactly what we have changed in each file.

[michielbdejong]

See #109 and #108

[michielbdejong]

And #110

[michielbdejong]

And #111

[thepeak99]

The OCM part is done the rest is still open.

[yasharpm]

Done for the OCM to groups app in the following commits:
pondersource@6732f66
pondersource@894ec49
pondersource@b2bb556