-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
code structure cleanup #104
Comments
For the FederatedShareProvider it's probably best if we copy it, make some private methods protected, and then inherit from it for the FederatedGroupsShareProvider. |
One thing we could do is, for each file we copied&modified from core apps, do a diff against the unchanged version of the file, so we can see exactly what we have changed in each file. |
And #110 |
And #111 |
The OCM part is done the rest is still open. |
Done for the OCM to groups app in the following commits: |
I just noticed there is some code still in the createFederatedShare method of federatedgroups/lib/FederatedFileSharing/FederatedShareProvider that should be in federatedgroups/lib/FederatedGroupsShareProvider
We need to make a map of which parts of the existing core apps code we are replacing with a user-and-groups-capable variant, and which parts we are doubling up with an additional groups-capable child class. For the FederatedShareProvider we now have federatedgroups/lib/FederatedGroupsShareProvider so federatedgroups/lib/FederatedFileSharing/FederatedShareProvider should probably not even exist, right?
The text was updated successfully, but these errors were encountered: