From 00ecf41b846056938586725f195c2845088ca087 Mon Sep 17 00:00:00 2001 From: linglp Date: Mon, 31 Jul 2023 15:00:06 -0400 Subject: [PATCH 1/2] rename function --- schematic/manifest/generator.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/schematic/manifest/generator.py b/schematic/manifest/generator.py index fc01457a3..6aa028d81 100644 --- a/schematic/manifest/generator.py +++ b/schematic/manifest/generator.py @@ -886,7 +886,7 @@ def _request_note_valid_values(self, i, req, validation_rules, valid_values): else: return - def _request_notes_comments(self, i, req, json_schema): + def _set_required_columns_color(self, i, req, json_schema): """Update background colors so that columns that are required are highlighted Args: i (int): column index @@ -1127,7 +1127,7 @@ def _create_requests_body( requests_body["requests"].append(get_row_formatting) # Add notes to headers to provide descriptions of the attribute - header_notes = self._request_notes_comments(i, req, json_schema) + header_notes = self._set_required_columns_color(i, req, json_schema) if header_notes: requests_body["requests"].append(header_notes) # Add note on how to use multi-select, when appropriate From 074f4b772ec8ac942fe2a4fe47ead9b5221e223c Mon Sep 17 00:00:00 2001 From: linglp Date: Mon, 31 Jul 2023 18:00:58 -0400 Subject: [PATCH 2/2] edit comment --- schematic/manifest/generator.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/schematic/manifest/generator.py b/schematic/manifest/generator.py index 6aa028d81..4c8c1740b 100644 --- a/schematic/manifest/generator.py +++ b/schematic/manifest/generator.py @@ -1126,10 +1126,10 @@ def _create_requests_body( if get_row_formatting: requests_body["requests"].append(get_row_formatting) - # Add notes to headers to provide descriptions of the attribute - header_notes = self._set_required_columns_color(i, req, json_schema) - if header_notes: - requests_body["requests"].append(header_notes) + # set color of required columns to blue + required_columns_color = self._set_required_columns_color(i, req, json_schema) + if required_columns_color: + requests_body["requests"].append(required_columns_color) # Add note on how to use multi-select, when appropriate note_vv = self._request_note_valid_values( i, req, validation_rules, valid_values